-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-74 - Collaborative awareness #71
Conversation
If the user is know their initial is displayed. If the user is not known a generic 'user' icon is displayed. When hovering over the icon the full name is shown as a tooltip. When collab is disconnected disable the editor until it reconnects.
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Also react to network (dis)connects as reported by the browser. Make firstUpdate async to give the ydoc a chance to init itself.
Test URL: https://awrz2--da-live--adobe.hlx.page/edit#/adobecom/da-milo-college/demo From my commit message:
Left out of commit message:
To do later: Bigger picture thoughts:
Observation: Edit: Fixed. |
Ugh. The tests broke as a result of moving prose/index to being data based instead of DOM based. I'll try to get these updated tomorrow. I think it should be relatively simple as we now can check for properties on a |
* Simplified integration between prose/index and da-title. * prose/index only responsible for data, da-title is presentation. * Turned user icon into clickable initial pill. Clicking shows full name popover. * Cloud is also clickable for more detailed status
Description
Show the currently editing other users as little icons in the top right corner:
![editing](https://private-user-images.githubusercontent.com/226514/308594453-f3d446e6-6f98-4598-b987-367cfc4997e3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODI1NjUsIm5iZiI6MTczOTU4MjI2NSwicGF0aCI6Ii8yMjY1MTQvMzA4NTk0NDUzLWYzZDQ0NmU2LTZmOTgtNDU5OC1iOTg3LTM2N2NmYzQ5OTdlMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwMTE3NDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05MDM4NTA0ZjJhYzI5ODc3MDVkZDY4ZWQxNjAwNzgwZTk4NmNkNjRjNjhmNjA5YTBiNmYyMDI4N2JkY2M2ZGJmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.JiTmlJg7gsNyok1u0JsWMBiVlov5bUApuP7mmOYs4Ro)
When the editor is disconnected from da-collab, or the network in general, show this via a disconnected cloud icon.
Motivation and Context
To make the editing more robust in case of a disconnection with da-collab and also to provide awareness of other users active in the document.
Types of changes
Checklist:
Release notes
Resolves: GH-74