Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support custom axis for Bar chart #435

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

pratyushbanerjee
Copy link
Contributor

@pratyushbanerjee pratyushbanerjee commented Oct 15, 2024

Description

Support custom axis for Bar chart. This allows correctly rendering axes when Line chart has larger scale than Bar chart in Combo chart

<Combo dimension="datetime">
  <Axis position="left" name="people" title="People" />
  <Axis position="right" name="total" title="Total" />
  <Bar metric="people" metricAxis="people" />
  <Line metric="total" metricAxis="total" />
</Combo>

Related Issue

#364

Motivation and Context

Support dual axes with larger scale for Line in Combo chart

How Has This Been Tested?

Passed existing tests
Updated tests to cover changes

Screenshots (if appropriate):

Before After

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

sonarqubecloud bot commented Oct 15, 2024

@marshallpete marshallpete merged commit c5c1eeb into adobe:main Oct 16, 2024
5 checks passed
@pratyushbanerjee pratyushbanerjee deleted the combo-bar-axis branch October 16, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants