chore: Update test util doc examples so they don't error out #7612
Conversation
| @@ -1012,7 +1012,7 @@ it('ComboBox can select an option via keyboard', async function () { | |||
| // Render your test component/app and initialize the combobox tester | |||
| let {getByTestId} = render( | |||
| <Provider theme={defaultTheme}> | |||
| <ComboBox data-testid="test-combobox"> | |||
| <ComboBox label="test-combobox" data-testid="test-combobox"> | |||
There was a problem hiding this comment.
do we need this in the example? do we need both attributes?
There was a problem hiding this comment.
I guess because of the warning about missing label? I think it's probably ok to keep the docs example minimal even so. we're omitting all of the content here as well
There was a problem hiding this comment.
yeah it was cuz of the missing labels, but I'm fine getting rid of it again
@snowystinger |
|
@snowystinger to check these I basically copy pasted them into our test suite and made sure they ran after filling in the contents. They were originally constructed from test cases we already had but messed some of them up when paring them down/copying them over. |
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: