Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add animation end callbacks #7633

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cprussin
Copy link

@cprussin cprussin commented Jan 18, 2025

This PR adds onEnterComplete and onExitComplete callbacks to components in react-aria-components which have enter and exit animations.

Closes #7630.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Write a component that has an enter or exit animation and pass the relevant onEnterComplete or onExitComplete hook and observe that it is triggered as expected.

🧢 Your Project:

Douro Labs (supporting https://pyth.network/)

This PR adds `onEnterComplete` and `onExitComplete` callbacks to components in
`react-aria-components` which have enter and exit animations.

Closes adobe#7630.
@cprussin cprussin force-pushed the add-animation-end-callbacks branch from 5f98303 to 951c9a2 Compare January 19, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add animation complete callbacks
1 participant