Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

byContentVal does not update in cases where there are no children #14

Open
cuberoot opened this issue Mar 22, 2019 · 0 comments
Open

byContentVal does not update in cases where there are no children #14

cuberoot opened this issue Mar 22, 2019 · 0 comments

Comments

@cuberoot
Copy link
Contributor

Expected Behaviour

A simple model like this should update if the contents of the node changes:

class ButtonModel extends DOMModel {
    @byContentVal() label;
}

Actual Behaviour

The initial contents of the DOM node is read, but the model does not respond to changes

Reproduce Scenario (including but not limited to)

Any use of the byContentVal decorator that isn't in a child node

Steps to Reproduce

I will submit a PR that includes a test case

Platform and Version

Chrome 72, MacOS

Sample Code that illustrates the problem

I will submit a PR that includes a test case

Logs taken while reproducing problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant