Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bycontentval fix #16

Closed
wants to merge 2 commits into from
Closed

Conversation

alexdixon
Copy link

Makes the byContentVal decorator update like the other decorators, even when not used in a child node.

Related Issue

#14

Motivation and Context

We have some UI that does not update because of this issue

How Has This Been Tested?

I have tested this in my application, and I have included a test case

Screenshots (if appropriate):

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
    New feature (non-breaking change which adds functionality)
    Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x ] I have signed the Adobe Open Source CLA.
[x ] My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
[x ] I have read the CONTRIBUTING document.
[x ] I have added tests to cover my changes.
[x ] All new and existing tests passed.

@alexdixon alexdixon closed this Mar 22, 2019
@alexdixon alexdixon reopened this Mar 22, 2019
@alexdixon alexdixon closed this Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants