Add evaluateRulesets action, subscribeRulesetItems event for "in browser messages" beta #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approval pending the beta badges from #353 |
|
this PR will need to be modified to support moving |
…eta badges, move decisionContext to be inside personalization object.
|
Looks good, @jonsnyder, thank you for making the edits. |
jfkhoury
approved these changes
Oct 27, 2023
carterworks
approved these changes
Oct 27, 2023
| const items = [...parent]; | ||
| const currentIndex = items.indexOf(item); | ||
| const previousItems = items.slice(0, currentIndex); | ||
| console.log("unique key validator 2", currentIndex, previousItems); |
There was a problem hiding this comment.
TODO (eventually): remove this console log
| @@ -29,6 +29,7 @@ const FormikComboBox = ({ name, width, validate, ...otherProps }) => { | |||
| name, | |||
| validate | |||
| }); | |||
| console.log("FormikComboBox", otherProps); | |||
There was a problem hiding this comment.
TODO (eventually): remove this console log
jasonwaters
approved these changes
Oct 27, 2023
| notice({ | ||
| title: "Evaluate rulesets action", | ||
| description: | ||
| "This action manually triggers ruleset evaluation. Rulesets are returned from Adobe Journey Optimizer in-browser-messages.", |
There was a problem hiding this comment.
I would revise this just a tad:
This action manually triggers ruleset evaluation. Rulesets are returned by Adobe Journey Optimizer to support features like in-browser messages.
jonsnyder
added a commit
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds evaluateRulesets action, and subscribeRulesetItems event for the In browser messages beta work. It also adds a field in sendEvent for "decisionContext".
I still need to add functional tests, and add beta labels.
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: