Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple test app #71

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lukem235
Copy link

Test app for host <--> guest connection

Copy link

@ahajji87 ahajji87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the .github workflow file (.github/workflows/e2e-tests.yml)

}
}
}
console.log('extension: ', extensions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this log is needed here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

const extension = extensions[0];
if (extension) {
extension.apis.extensionNamespace.setMessage('Message from host').then(info => {
console.log(info);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this log is for debugging right? if the guest shows the message "Message from host" in the UI we can remove this '.then()'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@lukem235
Copy link
Author

I don't see the .github workflow file (.github/workflows/e2e-tests.yml)

Thanks for that, I added missing file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants