Skip to content

Commit

Permalink
chore: drop support for ember 3.25
Browse files Browse the repository at this point in the history
  • Loading branch information
gilest committed Dec 23, 2023
1 parent 3c2e01c commit e4bdc37
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 27 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ jobs:
matrix:
ember-try-scenario:
[
ember-3.25,
ember-lts-3.28,
ember-release,
ember-beta,
Expand Down
6 changes: 1 addition & 5 deletions ember-file-upload/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,12 @@ Uploads can be managed through queues and continue in the background, even after

## Compatibility

* Ember.js 3.25 or above
* Ember.js 3.28 or above
* TypeScript 5.0 or above
* ember-auto-import 2.0 or above
* Ember CLI v2.13 or above
* Node.js v16 or above
* Modern browsers. Internet Explorer 11 might work but is not offically supported.
* Strict Content Security Policy (CSP) except for mirage route handlers, which require `data:` protocol to be included in `image-src` and `media-src` directives.

For Ember.js < 3.25 use 4.x which is documented by [Legacy docs](https://adopted-ember-addons.github.io/ember-file-upload/docs/).

## Upgrading

See: [Upgrade guide](https://ember-file-upload.pages.dev/docs/upgrade-guide).
Expand Down
11 changes: 0 additions & 11 deletions test-app/config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,6 @@ module.exports = async function () {
return {
usePnpm: true,
scenarios: [
{
name: 'ember-3.25',
npm: {
devDependencies: {
'ember-cli': '~4.12.2',
'ember-source': '~3.25.4',
'@ember/test-helpers': '^2.9.4',
'ember-qunit': '~6.0.0',
},
},
},
{
name: 'ember-lts-3.28',
npm: {
Expand Down
10 changes: 0 additions & 10 deletions test-app/tests/helpers/file-queue-helper-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -203,16 +203,6 @@ module('Integration | Helper | file-queue', function (hooks) {
test('will be notified when an upload fails', async function (this: LocalContext, assert) {
assert.expect(5);

// Required for Ember 3.25 run only
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
if (window.Ember) {
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
// eslint-disable-next-line @typescript-eslint/no-empty-function
window.Ember.onerror = function () {};
}

this.server.post(
'/upload-file',
uploadHandler(() => new MirageResponse(500)),
Expand Down

0 comments on commit e4bdc37

Please sign in to comment.