Migrate all tests to "strict mode" #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilest
changed the title
gilest
added a commit
that referenced
this pull request
Dec 25, 2023
Raises minimum supported version to 3.28 Purpose is to allow us to use "strict" mode in the test app (#1048 #1049) Feel this is reasonable as we still support the final release in 3.x series Thinking I will merge but not bother releasing until we have other changes to release also Would be good if there were other breaking changes to batch, but I'm not aware of any
gilest
force-pushed
the
tests/more-gts
branch
from
debdb31 to
78e3db9
Compare
gilest
force-pushed
the
tests/more-gts
branch
from
8fde7a6 to
4d5a3af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased off #1048 so the diff will include those changes until they are merged