-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow dropping a folder into the dropzone #1066
Open
gvdp
wants to merge
11
commits into
adopted-ember-addons:master
Choose a base branch
from
Bagaar:allow-folder-drop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3cad399
feat: allow dropping a folder into the dropzone
7560c34
wrap getWebkitAsEntry method to be future proof if API changes
01007f9
remove unnecessary getter
8378fd2
fix typo in interface
3ef7bfd
implement code readability suggestions
468e5bf
fix: dont report foldernames and dont throw errors when there are sub…
3d58723
remove console log
8770ea8
pass folderName to UploadFile object when dropping folders
a2faaac
fix: resolve and log warning when a subdirectory is dropped
fa3d8a1
fix: recursively read folder entries because most browsers only retur…
9119b21
Merge pull request #1 from Bagaar/fix/recursively-read-large-folders
gvdp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
implement code readability suggestions
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Perf] All of the child functions defined within
getFilesAndDirectories
do not rely on class state or local variable closure.Because of this, they only need to be defined once in memory, rather than every time this methodn is called.
Let's move all of the child functions to module scope (you can put them in the top of this file).
I think extracting them also helps with readability of this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved all the functions to the top.