Tweetest Prep work for jacoco tests #2432
Labels
docs
good first issue
type:external
3rd party application tests (invoked by the make target 'external')
Milestone
👾 Description of the issue
We run external third-party application tests at this project. They are contained within the external directory. We would like to improve how we run these tests. The first step to improving how we run them is to add some documentation and to pull out the individual test properties that we use so that they are stored in the same directory as the test.
This issue is to add a README.md and a test.properties file to the /external/jacoco test directory. As part of this prep work, since we already generate the Dockerfile, please also remove the static https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/jacoco/dockerfile/Dockerfile.
The contents of the README file can be simply some instructions for how to run the test locally. Use with the instructions from https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/README.md#running-external-tests-locally and modify Steps 7 and 9 to reference jacoco and jacoco_test specifically.
The contents of the test.properties file will be a key=value format, copying the information from https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/common_functions.sh#L239-L251 to populate it.
Adding these files will not change the current way we run these tests. A separate change will be made to reference the test.properties file, at which point the contents must match those in the common_functions.sh script.
Please take the time to try and run the test locally (using the instructions you are adding in the README file). Some of the external tests are failing. When you run it locally, you may find that to be the case. The reviewer can help to advise you if there are any further steps you can take to try and debug the pre-existing failure, if it exists.
📋 Step by Step
To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here. Note: that you do not need to add yourself to a Contributors.md file as outlined in the detailed instructions.
🤔❓ Questions
If you have any questions just ask us directly in this issue by adding a comment. You can join our community chat at Slack. Next to this you can find a general manual about open source contributions here.
The text was updated successfully, but these errors were encountered: