add README, test.properties files #2538
Conversation
|
I've made the requested changes,, hope it's better now |
external/jacoco/README.md
Outdated
| @@ -0,0 +1,22 @@ | |||
| Running External Jacoco tests locally | |||
There was a problem hiding this comment.
Please add following part before this Running External Jacoco tests locally
External Jacoco Tests
Jacoco tests are part of the external third-party application tests that help verify that the Adoptium binaries are good, by running a variety of Java applications inside of Docker containers. AdoptOpenJDK/openjdk-tests/Issue #172 lists the applications that we have initially targeted to best exercise the AdoptOpenJDK binaries. For each application, we choose to run a selection of their functional tests.
Jacoco test material is pulled from the Jacoco repository.
external/jacoco/README.md
Outdated
|
|
||
| 8. <make compile> (This fetches test material and compiles it, based on build.xml files in the test directories) | ||
|
|
||
| 9.<make _jacoco_test> (When you defined BUILD_LIST to point to a directory in openjdk-tests/external, then this is a testCaseName from the playlist.xml file within the directory you chose) |
There was a problem hiding this comment.
Please also add following part as the last section:
When running these from the command-line, these tests are grouped under a make target called 'external', so 'make external' would run the entire set of tests found in the openjdk-tests/external directory. This is unadvisable! Limit what you compile and run, BUILD_LIST=external/<someSubDirectory>, and TARGET=<testCaseNameFromSubdirPlaylist>
These tests run regularly and results can be found in TRSS Third Party Application view.
There was a problem hiding this comment.
Also please update the layout. See the example https://github.com/AdoptOpenJDK/openjdk-tests/pull/2473/files
|
I've done the requested changes, however not totally sure about the layout |
external/jacoco/README.md
Outdated
| @@ -0,0 +1,22 @@ | |||
| ##External Jacoco Tests | |||
There was a problem hiding this comment.
Please update to # External Jacoco Tests ( note there is a space between # and External. It's a format of Markdown).
external/jacoco/README.md
Outdated
| Jacoco tests are part of the external third-party application tests that help verify that the Adoptium binaries are good, by running a variety of Java applications inside of Docker containers. AdoptOpenJDK/openjdk-tests/Issue #172 lists the applications that we have initially targeted to best exercise the AdoptOpenJDK binaries. For each application, we choose to run a selection of their functional tests. | ||
| Jacoco test material is pulled from the [Jacoco repository](https://github.com/jacoco/jacoco). | ||
|
|
||
| ##Running External Jacoco tests locally |
There was a problem hiding this comment.
Same here. There is a space between # and Running .....
|
Just two minor issues. Others looks good. |
|
they are fixed now. Thank you |
|
Thanks @mara-ber |
Fixes #2432