Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Apache Camel tests into external group #1615

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

LongyuZhang
Copy link
Contributor

  • added Apache Camel in the external group

issue: #1608

Signed-off-by: Longyu Zhang [email protected]

@LongyuZhang
Copy link
Contributor Author

LongyuZhang commented Feb 13, 2020

@smlambert
Copy link
Contributor

Thanks @LongyuZhang - can I also get you to update the common_functions.sh script (in supported_tests: https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/common_functions.sh#L34
and in the case statement: https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/common_functions.sh#L179)?

@LongyuZhang LongyuZhang force-pushed the camel1 branch 5 times, most recently from e5fb891 to 01b5e8b Compare February 13, 2020 19:25
- added Apache Camel in the external group

issue: adoptium#1608

Signed-off-by: Longyu Zhang <[email protected]>
@LongyuZhang
Copy link
Contributor Author

@smlambert The suggested content has been added to common_functions.sh and tested locally, thanks.

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks @LongyuZhang !

@smlambert smlambert merged commit fc115ea into adoptium:master Feb 13, 2020
@james-crowley
Copy link
Contributor

@LongyuZhang @smlambert Just noticed you guys add a new test case via the Docker framework!!!!!! This is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants