Completed prep work for quarkus_openshift tests #2454
Conversation
There was a problem hiding this comment.
hi @SAY-droid427 - some minor changes requested, otherwise, looking pretty good!
external/quarkus_openshift/README.md
Outdated
| @@ -0,0 +1,31 @@ | |||
| # External quarkus_openshift Tests | |||
|
|
|||
| Third Party container tests help verify that the Adoptium binaries are good by running a variety of Java applications inside of Docker containers. AdoptOpenJDK/openjdk-tests/Issue #172 lists the applications that we have initially targeted to best exercise the AdoptOpenJDK binaries. For each application, we choose to run a selection of their functional tests. | |||
There was a problem hiding this comment.
Please replace 'AdoptOpenJDK binaries' with 'Adoptium binaries' and hyperlink #172 with link to that issue #172
Please add a couple more sentences that say:
Quarkus Openshift tests are pulled from the quarkus-openshift-test-suite repository. These tests require an Openshift cluster environment to run.
*hyperlink quarkus-openshift-test-suite with the github_url value from test.propertis
external/quarkus_openshift/README.md
Outdated
|
|
||
| When [running these from the command-line](https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/doc/userGuide.md#local-testing-via-make-targets-on-the-commandline), these tests are grouped under a make target called 'external', so 'make external' would run the entire set of tests found in the openjdk-tests/external directory. This is unadvisable! Limit what you compile and run, BUILD_LIST=external/`<someSubDirectory>`, and TARGET=`<testCaseNameFromSubdirPlaylist>`. | ||
|
|
||
| These tests run regularly and results can be found in [TRSS Third Party Application view](https://trss.adoptopenjdk.net/ThirdPartyAppVie). |
There was a problem hiding this comment.
missing 'w' from the end of ThirdPartyAppView
external/quarkus_openshift/README.md
Outdated
| @@ -0,0 +1,31 @@ | |||
| # External quarkus_openshift Tests | |||
|
|
|||
| Third Party container tests help verify that the Adoptium binaries are good by running a variety of Java applications inside of Docker containers. AdoptOpenJDK/openjdk-tests/Issue [#172](https://github.com/AdoptOpenJDK/openjdk-tests/issues/172) lists the applications that we have initially targeted to best exercise the Adoptium binaries. For each application, we choose to run a selection of their functional tests. Quarkus Openshift tests are pulled from the [quarkus-openshift-test-suite](https://github.com/quarkus-qe/quarkus-openshift-test-suite.git) repository. These tests require an Openshift cluster environment to run. | |||
There was a problem hiding this comment.
Please change the first part of the sentence to be:
Quarkus_openshift tests are part of the external third-party application tests that help verify that the Adoptium binaries are good...
Other than that, all is good to me.
|
Please also sign off your commit and update your comment #2454 (comment) with Close #2442 , which will automatically close the issue #2242 when this PR is merged. |
Signed-off-by: SAY-droid427 <[email protected]>
Completed prep work for quarkus_openshift tests
Close #2442