Prep work for derby tests #2490
Conversation
|
@smlambert Please review this PR |
external/derby/test.properties
Outdated
| @@ -0,0 +1,13 @@ | |||
| github_url="https://github.com/apache/derby.git" | |||
| script="derby-test.sh" | |||
external/derby/README.md
Outdated
| @@ -0,0 +1,14 @@ | |||
| ## Running External tests locally | |||
There was a problem hiding this comment.
Please add another section before this:
External derby Tests
Derby tests are part of the external third-party application tests that help verify that the Adoptium binaries are good by running a variety of Java applications inside of Docker containers. AdoptOpenJDK/openjdk-tests/Issue #172 lists the applications that we have initially targeted to best exercise the Adoptium binaries. For each application, we choose to run a selection of their functional tests. Quarkus Openshift tests are pulled from the apache/derby repository.
There was a problem hiding this comment.
Please change the heading to:
Running External derby tests locally
external/derby/README.md
Outdated
| 1. `cd openjdk-tests` | ||
| 1. `./get.sh` | ||
| 1. `cd TKG` | ||
| 1. export required environment variables, BUILD_LIST and EXTRA_DOCKER_ARGS (example: `export BUILD_LIST=external/jacoco` and `export EXTRA_DOCKER_ARGS="-v $TEST_JDK_HOME:/opt/java/openjdk"` |
There was a problem hiding this comment.
BUILD_LIST=external/derby
| 1. `cd TKG` | ||
| 1. export required environment variables, BUILD_LIST and EXTRA_DOCKER_ARGS (example: `export BUILD_LIST=external/jacoco` and `export EXTRA_DOCKER_ARGS="-v $TEST_JDK_HOME:/opt/java/openjdk"` | ||
| 1. `make compile` (This fetches test material and compiles it, based on build.xml files in the test directories) | ||
| 1. `make _derby_test` (When you defined BUILD_LIST to point to a directory in [openjdk-tests/external](https://github.com/AdoptOpenJDK/openjdk-tests/tree/master/external), then this is a testCaseName from the playlist.xml file within the directory you chose) |
There was a problem hiding this comment.
Please add the following as the last section:
When running these from the command-line, these tests are grouped under a make target called 'external', so 'make external' would run the entire set of tests found in the openjdk-tests/external directory. This is unadvisable! Limit what you compile and run, BUILD_LIST=external/<someSubDirectory>, and TARGET=<testCaseNameFromSubdirPlaylist>
These tests run regularly and results can be found in TRSS Third Party Application view.
There was a problem hiding this comment.
Thanks @khushishikhu - I have requested a few changes. Also as per the issue description, please delete https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/derby/dockerfile/Dockerfile which is no longer used or needed, since Dockerfiles are auto-generated now.
external/derby/README.md
Outdated
| 1. `cd openjdk-tests` | ||
| 1. `./get.sh` | ||
| 1. `cd TKG` | ||
| 1. export required environment variables, BUILD_LIST and EXTRA_DOCKER_ARGS (example: `export BUILD_LIST=external/jacoco` and `export EXTRA_DOCKER_ARGS="-v $TEST_JDK_HOME:/opt/java/openjdk"` |
There was a problem hiding this comment.
please use
export BUILD_LIST=external/derby rather than jacoco as the example
external/derby/test.properties
Outdated
| @@ -0,0 +1,13 @@ | |||
| github_url="https://github.com/apache/derby.git" | |||
| script="derby-test.sh" | |||
There was a problem hiding this comment.
Remove indentation for all lines that have it (so all lines are left-aligned like line 1)
external/derby/README.md
Outdated
| @@ -0,0 +1,14 @@ | |||
| ## Running External tests locally | |||
There was a problem hiding this comment.
Before this section add:
External Derby Tests
Derby tests are a part of the external third-party application tests that help verify that the Adoptium binaries are good by running a variety of Java applications inside of Docker containers. AdoptOpenJDK/openjdk-tests/Issue #172 lists the applications that we have initially targeted to best exercise the Adoptium binaries. For each application, we choose to run a selection of their functional tests. Derby test material is pulled from the derby repository.
Then also change the heading "Running External tests locally" to be "Running Derby tests locally"
|
@smlambert @sophia-guo Thank you for reviewing the PR. I have done the suggested changes. Please check now |
external/derby/README.md
Outdated
| @@ -0,0 +1,22 @@ | |||
| # External (Third Party Container) Tests | |||
There was a problem hiding this comment.
Please change
External (Third Party Container) Tests
to
External Derby Tests
external/derby/README.md
Outdated
| @@ -0,0 +1,22 @@ | |||
| # External (Third Party Container) Tests | |||
|
|
|||
| Third Party container tests help verify that the AdoptOpenJDK binaries are *good* by running a variety of Java applications inside of Docker containers. AdoptOpenJDK/openjdk-tests/[Issue #172](https://github.com/AdoptOpenJDK/openjdk-tests/issues/172) lists the applications that we have initially targeted to best exercise the AdoptOpenJDK binaries. For each application, we choose to run a selection of their functional tests. | |||
There was a problem hiding this comment.
Change
Third Party container tests help verify
to
Derby tests are a part of the external third-party application tests that help verify
|
@khushishikhu - are you able to make updates to this PR based on the last review comments above? |
|
Marking as stale and closing. This can be reopened and delivered if there are updates. |
Description
Fixes #2430
According to the issue, the documentation is written including all the required things asked for in the issue description
Please correct me in the PR if written wrong somewhere.
Thank You!!