Add tomcat into thirdparty_containers #316
Conversation
|
|
||
| <!-- set properties for this build --> | ||
| <property name="DEST" value="${BUILD_ROOT}/thirdparty_containers/tomcat-test" /> | ||
| <property name="dist" location="${DEST}/${JAVA_VERSION}" /> |
There was a problem hiding this comment.
With new TestKitGen we don't need the "dist" for different JAVA_VERSION any more. 'DEST' is enough.
There was a problem hiding this comment.
@sophia-guo - so what specific change are you asking for @chandrams to make? Are you asking to remove line 10, and any references elsewhere to dist?
There was a problem hiding this comment.
Yes, line 10 can be removed. Correspondingly line 15 should be changed
|
Is there a link to a personal build where you ran this change? |
|
Couldn't find the older runs, submitted one today - https://ci.adoptopenjdk.net/view/work%20in%20progress/job/test_personal/381/ |
| <property name="jvm_version" location="${JVM_VERSION}" /> | ||
|
|
||
| <target name="init"> | ||
| <mkdir dir="${dist}"/> |
There was a problem hiding this comment.
Change to <mkdir dir="${DEST}"/>
There was a problem hiding this comment.
I have made these changes, please review.
Signed-off-by: Chandrakala <[email protected]>
Included dockerfile and scripts to run tomcat tests for 8.5.24 version.
Issue #281
Signed-off-by: Chandrakala [email protected]