Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lucene-Solr standard test suite to External Tests #392

Merged
merged 1 commit into from
Apr 26, 2018

Conversation

Mesbah-Alam
Copy link
Contributor

@Mesbah-Alam Mesbah-Alam commented Apr 20, 2018

Add Lucene-Solr standard test suite to External tests

Signed-off-by: Mesbah [email protected]

@Mesbah-Alam Mesbah-Alam self-assigned this Apr 20, 2018
@Mesbah-Alam Mesbah-Alam requested a review from smlambert April 20, 2018 20:02
@Mesbah-Alam Mesbah-Alam changed the title Add Lucene-Solr nightly smoke test in third party container test bucket Add Lucene-Solr nightly smoke test to the External Tests Apr 20, 2018
@Mesbah-Alam Mesbah-Alam changed the title Add Lucene-Solr nightly smoke test to the External Tests Add Lucene-Solr nightly smoke test to External Tests Apr 20, 2018
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than minor changes in comments, lgtm

@@ -10,7 +10,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# This Dockerfile in thirdpart_containers/scala/dockerfile dir is used to create an image with
# This Dockerfile in thirdpart_containers/example-test/dockerfile dir is used to create an image with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, "in thirdpart_containers/..." missing the y from party

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

# See the License for the specific language governing permissions and
# limitations under the License.

# This Dockerfile in thirdpart_containers/lucene-solr/dockerfile dir is used to create an image with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same y missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@Mesbah-Alam Mesbah-Alam force-pushed the makeLuceneExample branch 17 times, most recently from 4e5fa99 to 73a1525 Compare April 26, 2018 19:13
@Mesbah-Alam
Copy link
Contributor Author

Mesbah-Alam commented Apr 26, 2018

Lucene solr tests are running in this personal build: https://urv-jenkins.canlab.ibm.com:9095/view/SV_Tests/job/test.personal/101/console

I had to add few options in the test command line for it to figure out where ivy home, ant/lib folder etc are located (e.g. -Divy_install_path=${ANT_HOME}/lib -lib ${ANT_HOME}/lib). This was the reason the test was failing in my earlier attempts to run. Also, had to add python3 to the list of software to be installed in the docker image-- there is a dependency of lucene-solr on that.

@Mesbah-Alam Mesbah-Alam changed the title Add Lucene-Solr nightly smoke test to External Tests Add Lucene-Solr standard test suite to External Tests Apr 26, 2018
@Mesbah-Alam Mesbah-Alam merged commit da5e4f3 into adoptium:master Apr 26, 2018
@Mesbah-Alam
Copy link
Contributor Author

Related issue: #172

@Mesbah-Alam Mesbah-Alam deleted the makeLuceneExample branch May 29, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants