-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lucene-Solr standard test suite to External Tests #392
Conversation
571744b
to
3503a5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than minor changes in comments, lgtm
@@ -10,7 +10,7 @@ | |||
# See the License for the specific language governing permissions and | |||
# limitations under the License. | |||
|
|||
# This Dockerfile in thirdpart_containers/scala/dockerfile dir is used to create an image with | |||
# This Dockerfile in thirdpart_containers/example-test/dockerfile dir is used to create an image with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo, "in thirdpart_containers/..." missing the y from party
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
# This Dockerfile in thirdpart_containers/lucene-solr/dockerfile dir is used to create an image with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same y missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
4e5fa99
to
73a1525
Compare
Lucene solr tests are running in this personal build: https://urv-jenkins.canlab.ibm.com:9095/view/SV_Tests/job/test.personal/101/console I had to add few options in the test command line for it to figure out where ivy home, ant/lib folder etc are located (e.g. |
Signed-off-by: Mesbah <[email protected]>
73a1525
to
87823ae
Compare
Related issue: #172 |
Add Lucene-Solr standard test suite to External tests
Signed-off-by: Mesbah [email protected]