Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Problematic Solaris x64 Test #5761

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

steelhead31
Copy link
Contributor

@steelhead31 steelhead31 commented Nov 19, 2024

Fixes adoptium/infrastructure#3684

Exclude javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java test for JDK8/Solaris x64, as it is a known upstream issue with a PR awaiting merge for jdk8u ( see : https://bugs.openjdk.org/browse/JDK-8212096 )

@steelhead31 steelhead31 changed the title Sfr test solaris Fix Problematic Solaris x64 Tests Nov 19, 2024
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on what we run. OpenJDK test material may or may not exist in the workspace. If OpenJDK file permission is not correct, please update them in the corresponding OpenJDK repo. Please do not make file permission changes in a common code.

@steelhead31
Copy link
Contributor Author

It depends on what we run. OpenJDK test material may or may not exist in the workspace. If OpenJDK file permission is not correct, please update them in the corresponding OpenJDK repo. Please do not make file permission changes in a common code.

Thanks @llxia , I'll move the permissions change upstream, and just have this PR handle the exclude.

@llxia
Copy link
Contributor

llxia commented Nov 19, 2024

Thanks @steelhead31

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 02edc24 into adoptium:master Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants