Add support for decompression of tar.xz in get.sh #5762
Conversation
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
|
The initial reason for the creation of #4374 to support xz was to support testing RHBO since it is packaged in that way (differently from the many other distributions that we support the testing of...). In that sense, I would not say it is a 'hard requirement' for us. It is certainly a nice to have for those wishing to test artifacts that are compressed in that way. I am not aware of a requirement for debugimage at the moment, but certainly fine to include it. |
| @@ -367,6 +367,12 @@ getBinaryOpenjdk() | |||
| for file_name in "${jdk_file_array[@]}" | |||
| do | |||
| if [[ ! "$file_name" =~ "sbom" ]]; then | |||
| if [[ $file_name == *xz ]]; then | |||
There was a problem hiding this comment.
Can we make the check more specific? Instead of checking xz, check
if [[ $file_name == *.tar.xz ]]; then
There was a problem hiding this comment.
The primary reason for not doing that is that .txz is also used by some people (same as .tgz is often used as a shorted .tar.gz), so this would catch that situation too .
sxa
changed the title
|
Please provide a Grinder link. |
For what specifically? |
|
Minimally 2 Grinders would be good, 1 to verify common use cases are unaffected, 1 to verify this works to decompress a RHBO from the marketplace would be helpful. |
|
and apologies, we've just merged Andrew's PR, so you'll need to resolve the conflicts in the get.sh file |
I figured I'd fire off an "upstream" one too to make sure those artifacts all work: https://ci.adoptium.net/job/Grinder/11608/ Hopefully that's adequate :-) |
Ah yes ... that's unfortunate |
|
Re-runs of the four above after mergeing in Andrew's change: |
Fixes #4374
A couple of points:
xzis on any given machine - maybe we should add it ... At the moment it'll just fail to extract with a message along the lines ofxz: not foundor similar.