Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tomcat playlist to copy the results from docker container #605

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

chandrams
Copy link
Contributor

@chandrams chandrams commented Oct 1, 2018

Updated playlist to copy the results from docker container

issue #976

Signed-off-by: Chandrakala [email protected]

@chandrams
Copy link
Contributor Author

@chandrams chandrams changed the title WIP: Updated playlist to copy the results from docker container WIP: Updated tomcat playlist to copy the results from docker container Oct 1, 2018
@karianna karianna added the bug label Oct 1, 2018
@Mesbah-Alam
Copy link
Contributor

@chandrams - Any update on this?

@smlambert
Copy link
Contributor

Festival of Lights in India, I suspect we will get an update on Thursday or after. :)

@chandrams
Copy link
Contributor Author

@Mesbah-Alam - Tomcat output logs aren't in the junit format. I have added the changes to copy the result logs though, let me know if you want to retain them.

@smlambert
Copy link
Contributor

What format are they? Some standard test output format?

@chandrams
Copy link
Contributor Author

Sorry I checked the wrong logs, they are in .txt format and I think they use junit.

cat TEST-org.apache.tomcat.websocket.TestWsSession.NIO.txt
Testsuite: org.apache.tomcat.websocket.TestWsSession
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.073 sec

Testcase: testAppendCloseReasonWithTruncation01 took 0.016 sec
Testcase: testAppendCloseReasonWithTruncation02 took 0 sec
Testcase: testAppendCloseReasonWithTruncation03 took 0.001 sec
Testcase: testAppendCloseReasonWithTruncation04 took 0.001 sec
Testcase: testAppendCloseReasonWithTruncation05 took 0 sec
Testcase: testAppendCloseReasonWithTruncation06 took 0.001 sec
Testcase: testAppendCloseReasonWithTruncation07 took 0.001 sec
Testcase: testAppendCloseReasonWithTruncation08 took 0.001 sec
Testcase: testAppendCloseReasonWithTruncation09 took 0.001 sec

@chandrams chandrams changed the title WIP: Updated tomcat playlist to copy the results from docker container Updated tomcat playlist to copy the results from docker container Dec 3, 2018
@smlambert
Copy link
Contributor

hi @chandrams - would you be able to update this PR to resolve conflicts? Then we can verify in a Grinder. Thanks!

@chandrams
Copy link
Contributor Author

Thanks Shelley @smlambert, I have resolved the conflicts.

@smlambert smlambert requested a review from sophia-guo March 19, 2019 18:08
@smlambert
Copy link
Contributor

May I request a review from you @sophia-guo as you have been working on external tests recently?

@@ -15,7 +15,9 @@
<playlist xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../TestConfig/playlist.xsd">
<test>
<testCaseName>tomcat_test</testCaseName>
<command>docker run --rm $(EXTRA_DOCKER_ARGS) adoptopenjdk-tomcat-test:latest ; \
<command>docker run --name tomcat-test $(EXTRA_DOCKER_ARGS) adoptopenjdk-tomcat-test:latest ; \
docker cp tomcat-test:/tomcat/output/build/logs $(REPORTDIR)/external_test_reports; \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest moving docker cp and docker rm after ${TEST_STATUS} like other tests. Otherwise the ${TEST_STATUS} will be determined by the status of docker rm.

Copy link
Contributor

@sophia-guo sophia-guo Mar 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also if tests pass ${TEST_STATUS} will clean the folder $(REPORTDIR). That means all copied files will be deleted. Nothing can be consumed by junit plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sophia have made the change. Please review.

@smlambert
Copy link
Contributor

@chandrams - when you get a chance, please update with @sophia-guo 's suggestions. Thanks!

@smlambert
Copy link
Contributor

@sophia-guo - ready for another review

@sophia-guo
Copy link
Contributor

Thanks @chandrams

@sophia-guo sophia-guo closed this Mar 27, 2019
@sophia-guo sophia-guo reopened this Mar 27, 2019
@sophia-guo sophia-guo merged commit 6ed6cdb into adoptium:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants