Packer: Install Xcode For Intel Macs. #3721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdams
reviewed
Aug 21, 2024
Co-authored-by: George Adams <[email protected]>
|
Can we perhaps skip the install of Xcode 11.7 on intel to speed things up? You'd need to make a change to the playbook to skip it on intel |
|
Added a comment to #3720 but I do wander if we'd be better off just running the reproducible tests on M1 hosts? Rosetta should be able to cope with this and it avoids us adding a massive package to the base image |
|
Also as things stand this will break the github action as we don't pass the XCode SAS token to the job https://github.com/adoptium/infrastructure/blob/master/.github/workflows/packer.yml#L44 |
|
I'll put this back into draft for the moment, as Im away now for the next 10 days, and it needs some further work & discussion. |
|
Not required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3720
Intel Macs now require Xcode for reproducible build tests.
Checklist