Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3-arg dot ambiguity #228

Merged
merged 6 commits into from
Feb 6, 2025
Merged

Fix 3-arg dot ambiguity #228

merged 6 commits into from
Feb 6, 2025

Conversation

adrhill
Copy link
Owner

@adrhill adrhill commented Feb 6, 2025

Hotfix closing #227 by only overloading dot on concrete array types. These currently only include Vector, Matrix and Subarray for #224.

In the long run, a more general solution should be found, e.g. using CasetteOverlay.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.77%. Comparing base (e2b2b00) to head (b5a71d8).

Files with missing lines Patch % Lines
src/overloads/arrays.jl 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   93.92%   93.77%   -0.15%     
==========================================
  Files          30       30              
  Lines        1168     1173       +5     
==========================================
+ Hits         1097     1100       +3     
- Misses         71       73       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrhill adrhill mentioned this pull request Feb 6, 2025
@adrhill adrhill merged commit 5ab81f5 into main Feb 6, 2025
11 checks passed
@adrhill adrhill deleted the ah/fix-dot-ambig branch February 6, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants