Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AbstractIndexSet typing #33

Merged
merged 3 commits into from
May 3, 2024
Merged

Remove AbstractIndexSet typing #33

merged 3 commits into from
May 3, 2024

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented May 3, 2024

Remove constraint S <: AbstractSet{<:Integer} in case we want to use vectors or other stuff.

Try to document the expectation of the tracer with respect to the "set" type.

See https://discourse.julialang.org/t/best-data-structure-for-fast-unions-of-large-sets-of-integers/113785/

src/tracers.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 71.48%. Comparing base (8bc5c4e) to head (da1d342).

Files Patch % Lines
src/tracers.jl 64.70% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   71.48%   71.48%           
=======================================
  Files           8        8           
  Lines         270      270           
=======================================
  Hits          193      193           
  Misses         77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Collaborator Author

gdalle commented May 3, 2024

I think this is ready, but I would rename all the occurrences of the set type to S. At the moment there is a mix of S and T. Thoughts?

@adrhill
Copy link
Owner

adrhill commented May 3, 2024

Yes, this is a good idea. T for tracer types, S for set types.

@gdalle
Copy link
Collaborator Author

gdalle commented May 3, 2024

I have put S in the few places I had spotted T, there might be more out there but I suggest we merge

@adrhill adrhill merged commit 8a9823e into main May 3, 2024
2 checks passed
@adrhill adrhill deleted the gd/relaxset branch May 3, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants