Fix for errors in Request Info panel for some core module settings pa…

…ges.
adrianbj · Feb 21, 2018 · 9baef12 · 9baef12
1 parent 097d4a4
commit 9baef12
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/TracyDebugger.module b/TracyDebugger.module
@@ -32,7 +32,7 @@ class TracyDebugger extends WireData implements Module, ConfigurableModule {
             'summary' => __('Tracy debugger from Nette with several PW specific custom tools.', __FILE__),
             'author' => 'Adrian Jones',
             'href' => 'https://processwire.com/talk/topic/12208-tracy-debugger/',
-            'version' => '4.9.18',
+            'version' => '4.9.19',
             'autoload' => true,
             'singular' => true,
             'requires'  => 'ProcessWire>=2.7.2, PHP>=5.4.4',

diff --git a/panels/RequestInfoPanel.php b/panels/RequestInfoPanel.php
@@ -167,7 +167,14 @@ public function getPanel() {
             if($this->wire('input')->get('name') && $this->wire('page')->process == 'ProcessModule') {
                 $moduleName = $this->wire('sanitizer')->name($this->wire('input')->get('name'));
                 if($this->wire('modules')->isInstalled($moduleName)) {
-                    $module = $this->wire('modules')->get($moduleName);
+                    // get was causing problems with some core modules like ProcessPageEdit and ProcessPageEditImageSelect
+                    // resulting in a "No page specified" error
+                    try {
+                        $moduleConfigData = $this->wire('modules')->get($moduleName);
+                    }
+                    catch(\Exception $e) {
+                        $moduleConfigData = $this->wire('modules')->getModuleConfigData($moduleName);
+                    }
                     $moduleSettings = '
                     <table>';
                     foreach($this->wire('modules')->getModuleInfoVerbose($moduleName) as $k => $v) {
@@ -178,7 +185,7 @@ public function getPanel() {
                             </tr>
                         ';
                     }
-                    foreach($module->getArray() as $k => $v) {
+                    foreach($moduleConfigData as $k => $v) {
                         $moduleSettings .= '
                             <tr>
                                 <td>'.$k.'</td>