Flexibility on the calculated gas price is added #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the issue with sending tx on POA network: due to the very low gas price required in there (1 Gwei), web3 might (and does) return 0 as median price. From that moment this given account is screwed, as txs will stuck for a long time.
I actually want to add more flexibility on the gas price, to be able to specify it per tx/contract/method, smth like Metamask has - Fast/Slow. This is pretty crucial for Ethereum Mainnet and can save lots of $$$ for tx fees.
Perhaps, smth to consider when implementing #36 ?