Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Adyen.Web Dropin/Components V6 #352

Merged
merged 12 commits into from
Jan 7, 2025
Merged

Conversation

Kwok-he-Chu
Copy link
Contributor

@Kwok-he-Chu Kwok-he-Chu commented Dec 17, 2024

Description
This PR addresses the upgrade to Adyen.Web Dropin v6.x.x (frontend), see: https://github.com/Adyen/adyen-web/releases/tag/v6.6.0

Additional steps

  • Moved v5 to its own /_archive/v5 folder
  • Updated the E2E tests workflow to allow it to run on the old (v5) and new (v6) versions respectively

The changes applies to the frontend: Adyen.Web Drop-in and Components (see Github)

Moved v5 to its own /_archive/v5 folder
@Kwok-he-Chu Kwok-he-Chu requested a review from a team as a code owner December 17, 2024 12:56
Copy link
Contributor

@gcatanese gcatanese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I have made some in-line comments

Copy link
Contributor

@gcatanese gcatanese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, we are almost there.
I have added some comments (note that I have made a comment but it applies to several files/components).

@Kwok-he-Chu Kwok-he-Chu requested a review from gcatanese January 7, 2025 14:16
@Kwok-he-Chu Kwok-he-Chu merged commit 25d0050 into main Jan 7, 2025
3 checks passed
@Kwok-he-Chu Kwok-he-Chu deleted the feat/upgrade-dropin-v6 branch January 7, 2025 14:50
@Kwok-he-Chu Kwok-he-Chu restored the feat/upgrade-dropin-v6 branch January 7, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants