Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Drop-in v6 #748

Merged
merged 19 commits into from
Jan 24, 2025
Merged

Add Drop-in v6 #748

merged 19 commits into from
Jan 24, 2025

Conversation

gcatanese
Copy link
Contributor

Upgrade Checkout and Advanced Checkout samples to Drop-in v6.

Kwok-he-Chu
Kwok-he-Chu reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@Kwok-he-Chu Kwok-he-Chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, minor changes. Mostly about some minor formatting and a couple of things that could be removed

checkout-example-advanced/public/klarna.js Outdated Show resolved Hide resolved
checkout-example-advanced/public/sepa.js Outdated Show resolved Hide resolved
checkout-example/public/googlepay.js Show resolved Hide resolved
checkout-example-advanced/public/klarna.js Outdated Show resolved Hide resolved
checkout-example-advanced/public/ideal.js Outdated Show resolved Hide resolved
checkout-example-advanced/public/ideal.js Outdated Show resolved Hide resolved
checkout-example-advanced/public/googlepay.js Show resolved Hide resolved
checkout-example-advanced/index.js Outdated Show resolved Hide resolved
.github/CODEOWNERS Show resolved Hide resolved
@gcatanese gcatanese requested a review from Kwok-he-Chu January 20, 2025 10:11
Kwok-he-Chu
Kwok-he-Chu reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Kwok-he-Chu Kwok-he-Chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

checkout-example-advanced/_archive/v5/index.js Outdated Show resolved Hide resolved
checkout-example-advanced/index.js Show resolved Hide resolved
checkout-example-advanced/index.js Outdated Show resolved Hide resolved
checkout-example-advanced/README.md Show resolved Hide resolved
checkout-example/views/index.handlebars Show resolved Hide resolved
@Kwok-he-Chu Kwok-he-Chu merged commit 600ccc1 into main Jan 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwok-he-Chu Kwok-he-Chu Kwok-he-Chu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcatanese @Kwok-he-Chu