ci: release build not completing

refactor to use pJson imports

eslint.config.js

@@ -10,6 +10,7 @@ import vitestPlugin from "eslint-plugin-vitest";
 import tseslint from "typescript-eslint";
 
 import compilerOptions from "./compilerOptions.js";
+import packageJson from "./package.json" with { type: "json" };
 
 export default tseslint.config(
   eslint.configs.recommended,
@@ -119,7 +120,9 @@ export default tseslint.config(
           newlinesBetween: "always",
           ignoreCase: false,
           type: "natural",
-          internalPattern: ["#/**"],
+          internalPattern: Object.keys(packageJson.imports).map((i) =>
+            i.endsWith("*") ? `${i}*` : i,
+          ),
           sortSideEffects: true,
           groups: [
             "builtin",

package.json

@@ -24,6 +24,9 @@
     "upgrade:react": "pnpm i --save react@experimental react-dom@experimental babel-plugin-react-compiler@experimental eslint-plugin-react-compiler@experimental eslint-plugin-react-hooks@experimental",
     "release": "./scripts/release.sh"
   },
+  "imports": {
+    "#/*": "./src/*"
+  },
   "pnpm": {
     "overrides": {
       "@ionic/core": "npm:[email protected]"

src/services/db.ts

@@ -9,9 +9,9 @@ import {
   PostSortType,
 } from "lemmy-js-client";
 
-import { COMMENT_SORTS } from "#/features/comment/CommentSort";
-import { ALL_POST_SORTS } from "#/features/feed/PostSort";
-import { arrayOfAll } from "#/helpers/array";
+import { COMMENT_SORTS } from "#/features/comment/CommentSort.js";
+import { ALL_POST_SORTS } from "#/features/feed/PostSort.js";
+import { arrayOfAll } from "#/helpers/array.js";
 
 export interface IPostMetadata {
   post_id: number;

tsconfig.json

@@ -1,25 +1,33 @@
 {
   "compilerOptions": {
     "target": "ESNext",
-    "useDefineForClassFields": true,
+
     "lib": ["DOM", "DOM.Iterable", "ESNext"],
-    "allowJs": false,
-    "skipLibCheck": true,
-    "esModuleInterop": false,
-    "allowSyntheticDefaultImports": true,
-    "strict": true,
-    "forceConsistentCasingInFileNames": true,
+
     "module": "ESNext",
-    "moduleResolution": "Node",
-    "resolveJsonModule": true,
-    "isolatedModules": true,
+    "moduleResolution": "bundler",
+    "resolvePackageJsonImports": true,
+
+    "strict": true,
     "noEmit": true,
+    "skipLibCheck": true,
+    "isolatedModules": true,
+    "allowJs": false,
+    "resolveJsonModule": true,
+
+    "forceConsistentCasingInFileNames": true,
+    "useDefineForClassFields": true,
+    "noUncheckedIndexedAccess": true,
+
     "jsx": "react-jsx",
     "types": ["vite-plugin-svgr/client"],
-    "noUncheckedIndexedAccess": true,
+
     "paths": {
+      // duplicate of package.json[imports]
+      // typescript doesn't support this same syntax in package.json with
+      // module resolution set to bundler, despite it working fine in esbuild/vite...
+      // https://github.com/microsoft/TypeScript/issues/55337 (╯°□°）╯︵ ┻━┻
       "#/*": ["./src/*"]
     }
-  },
-  "include": ["src"]
+  }
 }

vite.config.ts

@@ -1,9 +1,9 @@
 import legacy from "@vitejs/plugin-legacy";
 import react from "@vitejs/plugin-react";
 import wyw from "@wyw-in-js/vite";
+import { omitBy } from "es-toolkit";
 import { ManifestOptions, VitePWA } from "vite-plugin-pwa";
 import svgr from "vite-plugin-svgr";
-import tsconfigPaths from "vite-tsconfig-paths";
 import { defineConfig } from "vitest/config";
 
 import compilerOptions from "./compilerOptions";
@@ -21,7 +21,6 @@ const IGNORED_ROLLUP_WARNINGS = [
 // https://vitejs.dev/config/
 export default defineConfig({
   plugins: [
-    tsconfigPaths(),
     react({
       babel: {
         plugins: [["babel-plugin-react-compiler", compilerOptions]],
@@ -87,12 +86,16 @@ export default defineConfig({
       },
     },
   },
-  define: {
-    APP_VERSION: JSON.stringify(process.env.npm_package_version),
-    APP_BUILD: process.env.APP_BUILD && JSON.stringify(process.env.APP_BUILD),
-    APP_GIT_REF: JSON.stringify(process.env.APP_GIT_REF),
-    BUILD_FOSS_ONLY: !!process.env.BUILD_FOSS_ONLY,
-  },
+  // vite panics on empty strings
+  define: omitBy(
+    {
+      APP_VERSION: JSON.stringify(process.env.npm_package_version),
+      APP_BUILD: process.env.APP_BUILD && JSON.stringify(process.env.APP_BUILD),
+      APP_GIT_REF: JSON.stringify(process.env.APP_GIT_REF),
+      BUILD_FOSS_ONLY: !!process.env.BUILD_FOSS_ONLY,
+    },
+    (v) => !v,
+  ),
   test: {
     exclude: ["**/e2e/**", "**/node_modules/**"],
     globals: true,