SQL on FHIR view runner #1775
Open
SQL on FHIR view runner #1775
+44,103
−32,717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johngrimes
changed the title
johngrimes
added
new feature
johngrimes
reviewed
Feb 13, 2024
|
|
||
| final Optional<? extends ChildDefinition> maybeChildDef = definition.flatMap( | ||
| def -> def.getChildElement(elementName)) | ||
| .filter(ChildDefinition.class::isInstance); |
There was a problem hiding this comment.
Under what circumstances is this filter condition anything other than true?
… to match `main` (after combine Patient data update).
…for 'Task' resource.
…gration test session.
…y treat CodeableConcept as a single concept entity.
…. (othewise it pick's up AsynTest mocked database bean).
…only relevant for WebFlex apps.
… hadoop client runtime, which is not shipped with pathling but with Spark. The server docker image which used this version does not use avro.
…on configuration and adding explicit loading of 'sparklyr' before test run.
…ault pathling context.
… jar to be created as well.
|
@piotrszul Things that still need to be done before we can release this:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1775 +/- ##
============================================
- Coverage 85.41% 76.34% -9.08%
- Complexity 139 142 +3
============================================
Files 339 423 +84
Lines 7805 9082 +1277
Branches 519 633 +114
============================================
+ Hits 6667 6934 +267
- Misses 849 1736 +887
- Partials 289 412 +123 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to execute SQL on FHIR view definitions against data sources within the library API.
It also includes a comprehensive refactoring that integrates this new functionality with the rest of the code base and makes some changes that will improve performance across all of the different FHIRPath query operations.
Resolves #1438 and #1759.