chore: combine frontend and backend into single container #1512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was requested by Metin, as I understand, to simplify HC setup. I don't have a strong opinion about this approach, from one side it really simplifies things, it would allow updating frontend and backend at the same time, but this doesn't seem to be a good practice. In docker-compose I can specify a restart policy for the whole container, but not for its process. For example, what should happen if the backend process gets crushed? Should nginx also be stopped or should the backend restart automatically? Should it be restarted infinitely? Notify the container manager somehow?
This PR is supported by the Æternity Crypto Foundation
https://docs.docker.com/config/containers/multi-service_container/