Don't stringify properties with undefined values in flushToDOM (#5549)

aframevr · Jun 27, 2024 · 230d4f7 · 230d4f7
1 parent f6fe0c3
commit 230d4f7
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/core/schema.js b/src/core/schema.js
@@ -187,7 +187,9 @@ module.exports.stringifyProperties = function (propData, schema) {
       value = stringifyProperty(propValue, propDefinition);
       if (!propDefinition) { warn('Unknown component property: ' + propName); }
     }
-    stringifiedData[propName] = value;
+    if (value !== undefined) {
+      stringifiedData[propName] = value;
+    }
   }
   return stringifiedData;
 };

diff --git a/tests/core/component.test.js b/tests/core/component.test.js
@@ -1149,6 +1149,19 @@ suite('Component', function () {
       el.components.dummy.flushToDOM();
       assert.equal(HTMLElement.prototype.getAttribute.call(el, 'dummy'), 'isDurrr: false');
     });
+
+    test('omits cleared properties', function () {
+      var el = document.createElement('a-entity');
+      registerComponent('dummy', {
+        schema: {name: {type: 'string'}}
+      });
+      el.setAttribute('dummy', 'name', 'John');
+      el.components.dummy.flushToDOM();
+      assert.equal(HTMLElement.prototype.getAttribute.call(el, 'dummy'), 'name: John');
+      el.setAttribute('dummy', 'name', '');
+      el.components.dummy.flushToDOM();
+      assert.equal(HTMLElement.prototype.getAttribute.call(el, 'dummy'), '');
+    });
   });
 
   suite('play', function () {