[docs] Updates to aincraft tutorial and code #5380
Conversation
I can't tell if this is reasonably necessary or a workaround for a bug, but these changes got the scene to work for me.
|
|
||
| <a-entity id="teleHand" hand-controls="hand: left" teleport-controls></a-entity> | ||
| <a-entity id="blockHand" hand-controls="hand: right"></a-entity> | ||
| <a-entity id="player"> |
There was a problem hiding this comment.
Removing aframe script intentional?
There was a problem hiding this comment.
Yes, because I wanted to only show the code that was relevant to the section. I hadn't realized the code blocks were made to be executable on their own!
| @@ -425,16 +427,9 @@ that attaches the clicking laser to VR tracked controllers. Like the | |||
| `laser-controls` component. This time to the right hand: | |||
|
|
|||
| ```html | |||
| <script src="https://aframe.io/releases/1.4.0/aframe.min.js"></script> | |||
There was a problem hiding this comment.
Keep aframe script so example is copy pastable
| ground, but we can specify with `collisionEntities` to teleport on the blocks | ||
| *and* the ground using selectors. These properties are part of the API that the | ||
| `blink-controls` component was created with: | ||
| [blink-controls]: https://github.com/jure/aframe-blink-controls |
There was a problem hiding this comment.
These component references have been moved from the top to the bottom. Any reason? The less changes the easier to review a PR
|
|
||
| <!-- Camera --> | ||
| <a-camera> | ||
| <!-- Uncomment the line below to place blocks on desktop or mobile --> |
There was a problem hiding this comment.
Without that commented out, blocks were getting placed near the controller instead of a distance. This is on the Meta Quest 2 browser.
|
Thanks. I left some comments. |
|
I'm not super experienced with pull requests, so let me know if there's more I should do. I am not clear on the rationale for making the code blocks copy/pasteable, since the blocks are not runnable without |
You did great! thanks so much. Congrats on your first contribution 🎖️ |
Description:
The tutorial (and corresponding html file) was partially converted to use
aframe-blink-controlsinstead ofaframe-teleport-controlsand wouldn't run. With that fixed, the scene had a problem where blocks would spawn right on the controller instead of at the end of the raycaster.Changes proposed:
aframe-blink-controlsaframe-blink-controls.With these changes, I was able to finish the tutorial.