Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes in example #5424

Merged
merged 4 commits into from
Jan 7, 2024
Merged

Various fixes in example #5424

merged 4 commits into from
Jan 7, 2024

Conversation

mrxz
Copy link
Contributor

@mrxz mrxz commented Jan 6, 2024

Description:
Found several small mistakes in the examples.

Changes proposed:

  • Update usages of vr-mode-ui to xr-mode-ui
  • Omit crossorigin="anonymous" on <a-asset-item> tags as this has no effect
  • Remove components/attributes that no longer exist or don't do anything (auto-enter-vr and opacity on <a-entity>)
  • Change filter to filterLabels as the former doesn't exist on the real-world-meshing component
  • Fix typo accidentally using , as property delimiter instead of ;

@dmarcos
Copy link
Member

dmarcos commented Jan 6, 2024

Thanks so much. just a small change

@mrxz
Copy link
Contributor Author

mrxz commented Jan 6, 2024

Didn't know a new version of the environment component was already out. I took the liberty to update all instances in the examples as it's needed for proper colour management. Did end up removing the script from the mixed-reality/anchor example as it didn't use the environment in any way.

@dmarcos
Copy link
Member

dmarcos commented Jan 7, 2024

Thanks!

@dmarcos dmarcos merged commit be8592e into aframevr:master Jan 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants