Use native bind instead of custom implementation #5461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Throughout the code base both the native
Function.prototype.bind
and a customAFRAME.utils.bind
are used (about 50-50). The latter was introduced as a faster alternative (#1762). However, it seems that this is no longer the case and in fact performs worse:This PR removes it and introduces a small wrapper of the native
bind
in the place ofAFRAME.utils.bind
to avoid breaking any third party code using this utility, while still given them the same perf benefit from switching to native bind.Changes proposed:
utils/bind
with nativebind
AFRAME.utils.bind
that uses nativebind