Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and spelling #5462

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Fix typos and spelling #5462

merged 1 commit into from
Feb 13, 2024

Conversation

mrxz
Copy link
Contributor

@mrxz mrxz commented Feb 13, 2024

Description:
Let a spellchecker run on the code and fixed various typos and spelling mistakes.

I did briefly test integrating spellchecking in eslint, and while it works, the precommit hook becomes too slow and there are many false-positives (e.g. event names like xbuttonup). It might still be worthwhile to consider setting up some spellchecking tools/configuration along with an A-Frame specific wordlist.

Changes proposed:

  • Fixed various typos and spelling mistakes

@dmarcos
Copy link
Member

dmarcos commented Feb 13, 2024

Thanks. Wouldn't add it as a hook maybe something optional that can be run manually.

@dmarcos
Copy link
Member

dmarcos commented Feb 13, 2024

Thanks

@dmarcos dmarcos merged commit e62e800 into aframevr:master Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants