Apply waiting and timeout on all assets, not just img, audio and video #5491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The asset loading system differentiated between
<img>
,<audio>
,<video>
elements and the<a-asset-item>
elements. Only the former would be awaited and subject to the timeout, the<a-asset-item>
elements would use the normal 'wait till loaded' mechanism ofa-node.js
.Besides the timeout not applying to
<a-asset-items>
it opened the door for race conditions where the timeout could cause a concurrentsuper.load
resulting in twoloaded
events being emitted. This is the cause behind #5130This PR moves the
<a-asset-item>
handling intoa-assets
ensuring it waits on all assets in the same way. The timeout will now correctly cause theloading
event being emitted without awaiting any (pending) assets.Fixes #5130
Changes proposed:
<a-asset-item>
s ina-assets
a-assets
would emit twoloaded
events