Make isCompatibleTexture check stricter by requiring equal source #5529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The compatibility check for textures allowed changes of the underlying source. Depending on the state of the texture in Three.js this might actually not be supported, causing incorrect reference counting, potentially leading to an exception upon disposal of the texture.
Instead of trying to inspect the internal state to make a decision, it's easier to make the check considerably stricter. This PR now requires the source to match the prior source. While this does lead to more texture instance being created when changing images, the corresponding
Source
(actual image data) andWebGLTexture
resources remain shared whenever possible.Changes proposed:
isCompatibleTexture
check stricter by requiring source to match previous source.