Cursor component: improve xrselect rayOrigin logic #5606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Continuation of #5528 adding logic to convert the XRPose coming from WebXR into world space. Intended usage of
cursor="rayOrigin: xrselect"
is to place it on thea-scene
(similar torayOrigin: mouse
), but can also be placed elsewhere as the logic no longer depends on the entity it is on.Changes proposed:
rayOrigin
type to/fromxrselect
and when entering/leaving XRselectend
from a different input source would incorrectly reset theactiveXRInput
freezing the active input source.