Use simple pinch end threshold avoiding repeated pinch starts #5609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this needs some adjustment. Tried with this on Meta Quest 3 https://glitch.com/edit/#!/a-pickle-rick?path=index.html%3A10%3A44 Three script tags. One with this PR, master and 1.6.0. Master and 1.6.0 work as expected. I can pinch and grab the model. With this PR the model spins without control. |
That's unrelated to this PR. The model spinning already happened on master, but just got fixed in #5565. This PR didn't include that fix yet, but I've now rebased it. The reproduction in the linked issue (#5505) can also be used to test the change. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A partial revert of 8341329 fixing #5505.
Having a fixed pinch end distance that is larger than pinch start should avoid any repeated pinch start events. The original change was made to reduce/avoid a pinch being too "sticky", so I've kept the new pinch end distance closer to the pinch start than before as a compromise.
Main goal is to get the pinching behaviour in a reliable and working state again. Other solutions can be explored either in community components or incrementally refined in the core.
Changes proposed: