Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AG-12677 Add preventDefault for legentItemClick events #2611

Merged
merged 3 commits into from
Oct 3, 2024
Merged

AG-12677 Add preventDefault for legentItemClick events #2611

merged 3 commits into from
Oct 3, 2024

Conversation

jacobp100
Copy link
Contributor

@jacobp100 jacobp100 commented Oct 1, 2024 •
edited
Loading

@jacobp100 jacobp100 requested review from alantreadway and a team as code owners October 1, 2024 10:34
@jacobp100 jacobp100 marked this pull request as draft October 1, 2024 10:34
@Stephanemw
Copy link
Contributor

LGTM

@olegat
Copy link
Contributor

olegat commented Oct 1, 2024

LGTM, but please ensure:

  1. That the commit/PR have JIRA ticket.
  2. That the preventDefault() is tested with the keyboard

Optional: Add an automated test to verify preventDefault().

@jacobp100 jacobp100 changed the title Add preventDefault for legentItemClick events AG-12677 Add preventDefault for legentItemClick events Oct 3, 2024
@jacobp100 jacobp100 marked this pull request as ready for review October 3, 2024 09:37
@jacobp100 jacobp100 changed the title AG-12677 Add preventDefault for legentItemClick events AG-12677 Add preventDefault for legentItemClick events Oct 3, 2024
alantreadway
alantreadway approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@alantreadway alantreadway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alantreadway alantreadway merged commit df348af into latest Oct 3, 2024
24 of 25 checks passed
@alantreadway alantreadway deleted the legend-item-prevent-default branch October 3, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alantreadway alantreadway alantreadway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacobp100 @Stephanemw @olegat @alantreadway