AG-13349 Fix dragging events #3063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegat
force-pushed
the
AG-13349/fix_dragging_events
branch
from
8da28b4 to
1c22615
Compare
|
Snapshots automatically updated, please review before merge: diff |
olegat
force-pushed
the
AG-13349/fix_dragging_events
branch
from
1c22615 to
58204ba
Compare
|
Snapshots automatically updated, please review before merge: diff |
1 similar comment
|
Snapshots automatically updated, please review before merge: diff |
olegat
force-pushed
the
AG-13349/fix_dragging_events
branch
2 times, most recently
from
dd21746 to
bd556c0
Compare
packages/ag-charts-community/src/widget/widgetListenerInternal.ts
Outdated
Show resolved
Hide resolved
This fixes a bug where two sets of window event handlers (capture) are running when mousedown-ing an HTMLElement. For example, mousedown-ing a navigator handle would fire 'drag-start' on the <input> slider and .ag-charts-canvas-container.
Also remove the dragging logic in InteractionManager which is no longer in use.
This fixes tests in zoom.test.ts
This allows us to ignore drag events if WidgetListenerInternal.destroy() is called.
olegat
force-pushed
the
AG-13349/fix_dragging_events
branch
from
bd556c0 to
a4709c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-13349