Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to reflection interface changes #2380

Closed
wants to merge 1 commit into from

Conversation

cmcmA20
Copy link

@cmcmA20 cmcmA20 commented May 4, 2024

Downstream fix, see agda/agda#7247 agda/agda#7322
Do not merge before the parent PR

@gallais
Copy link
Member

gallais commented May 6, 2024

I'm not a fan of just having a Bool there.
Can we throw in a more informative sum type?

@cmcmA20
Copy link
Author

cmcmA20 commented May 6, 2024

Yeah, feel free to suggest what other info should be exposed.

@gallais
Copy link
Member

gallais commented May 6, 2024

I don't mean necessarily more information but a type with informative constructor names.

@cmcmA20 cmcmA20 force-pushed the reflection-and-erasure branch from a9ef4fa to a02be2e Compare May 7, 2024 01:03
@MatthewDaggitt
Copy link
Contributor

Hi @cmcmA20, thanks for the fix! Any chance you could make this against the experimental branch rather than the master branch? Changes to Agda itself don't usually go on master.

@MatthewDaggitt MatthewDaggitt added reflection upstream Changes induced by Agda upstream labels May 15, 2024
@MatthewDaggitt MatthewDaggitt modified the milestones: Agda-2.6.4, Agda-2.6.5 May 15, 2024
@cmcmA20 cmcmA20 changed the base branch from master to experimental May 22, 2024 03:26
@cmcmA20 cmcmA20 force-pushed the reflection-and-erasure branch from a02be2e to 38fc777 Compare May 22, 2024 03:41
@cmcmA20 cmcmA20 force-pushed the reflection-and-erasure branch from 38fc777 to 85ba8ef Compare June 16, 2024 02:11
@cmcmA20 cmcmA20 force-pushed the reflection-and-erasure branch from 85ba8ef to 22cf60e Compare June 29, 2024 10:10
@cmcmA20 cmcmA20 force-pushed the reflection-and-erasure branch from 22cf60e to 1727ec7 Compare June 29, 2024 10:29
@JacquesCarette
Copy link
Contributor

This is against milestone Agda-2.6.5 (which doesn't exist) but Agda-2.7 is out. Is this obsolete?

@cmcmA20
Copy link
Author

cmcmA20 commented Aug 24, 2024

@JacquesCarette
Sorry, I forgot about this PR!
Jesper and Andreas have already merged these changes in #2432.

@cmcmA20 cmcmA20 closed this Aug 24, 2024
@cmcmA20 cmcmA20 deleted the reflection-and-erasure branch August 24, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reflection upstream Changes induced by Agda upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants