Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ fix ] in non-commutative settings distinguish _∣ˡ_ and _∣ʳ_ #2604

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[ fix ] in non-commutative settings distinguish _∣ˡ_ and _∣ʳ_ #2604

wants to merge 8 commits into from
+304 −45

Conversation

gallais
Copy link
Member

@gallais gallais commented Feb 20, 2025

No description provided.

JacquesCarette
JacquesCarette approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

MatthewDaggitt
MatthewDaggitt requested changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@MatthewDaggitt MatthewDaggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good!

src/Data/List/Relation/Binary/Suffix/Homogeneous/Properties.agda Outdated
open import Relation.Binary.PropositionalEquality using (_≡_; refl; cong)
open import Relation.Binary using (_⇒_)

Suffix-as-∣ʳ : Suffix _≡_ ⇒ _∣ʳ_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these lemmas live in a new file Suffix.Propositional and Suffix.Propositional.Properties?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair; moved everything to Suffix.Propositional.Properties.
I did not define Suffix.Propositional because, just like the non-existent Suffix.Homogeneous,
it would be a single definition of an alias for the type constructor, wouldn't it?

@jamesmckinna jamesmckinna mentioned this pull request Feb 21, 2025
Open
3 tasks
@jamesmckinna
Copy link
Contributor

Very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewDaggitt MatthewDaggitt MatthewDaggitt requested changes

@JacquesCarette JacquesCarette JacquesCarette approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gallais @jamesmckinna @JacquesCarette @MatthewDaggitt