Update mp4ameta dependency #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v0.12 release brings a few performance improvements and allows more precise control over what data should be read. This avoids reading and allocating image data during indexing.
|
Thank you (both for the PR and nice work on the library)! All the code changes look good, but I think the test file ended up with two label fields instead of just the uppercase one it should have: |
|
Oh right, musicbrainz picard must have not recognized the old one :D |
|
Speaking of which... https://tickets.metabrainz.org/browse/PICARD-3029 |
|
Weird, that definitely works on my machine 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v0.12 release brings a few performance improvements and allows more precise control over what data should be read. This avoids reading and allocating image data during indexing.
On my collection that consists mainly of
m4afiles without embedded artworks, and using my own music-organizing tool this reduces the time of indexing from a very consistent170msto131ms. The polaris indexing time fluctuates a lot more in general but is also lower on average. On collections that also have embedded artworks this should be even faster.