Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change kernel cfg of drm from y to m to fix the pwm issue #1180 #1209

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

bigbearishappy
Copy link

- What I did
I was trying to fix the startup problem of the LCD driver in yocto.And I find that the kernel config in yocto of drm is different
with raspbianOS.So I change it same with raspbianOS. And it works fine.

Interestingly, I also find that the PWM issue I create in #1180 was fixed.

Copy link
Collaborator

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm although I wonder if it will affect images booting out of initramfs

@bigbearishappy
Copy link
Author

bigbearishappy commented Aug 2, 2023

Lgtm although I wonder if it will affect images booting out of initramfs

Oh, it's already tested with booting out of initramfs. And it works fine.

Copy link
Owner

@agherzan agherzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Can you please add your rationale in git log and have a format as per https://meta-raspberrypi.readthedocs.io/en/latest/contributing.html? Thanks.

…m issue agherzan#1180

When I was trying to drive a lcd(ili9881) with pwm backlight control.
I encountered with the problem in agherzan#1180.
After I check the kernel config of both raspbian OS and yocto.I find
the config of drm is different between them.
Detail of difference:
In raspbian OS, kernel conifg of drm is m while it's y in yocto.

So I change the config of drm to m in yocto too.And the pwm works fine now.

Signed-off-by: bigbearishappy <[email protected]>
@bigbearishappy
Copy link
Author

Interesting. Can you please add your rationale in git log and have a format as per https://meta-raspberrypi.readthedocs.io/en/latest/contributing.html? Thanks.

Thanks for your guidance. The git log is updated now. Please let me know if there is any further work I need to do.

@agherzan agherzan enabled auto-merge (rebase) August 3, 2023 07:45
@agherzan agherzan merged commit 80a12f7 into agherzan:kirkstone Aug 3, 2023
@agherzan
Copy link
Owner

agherzan commented Aug 4, 2023

@bigbearishappy is this issue specific to the kirkstone branch? Are you able to give it a spin on the master branch too?

@bigbearishappy
Copy link
Author

@bigbearishappy is this issue specific to the kirkstone branch? Are you able to give it a spin on the master branch too?

I think it's not a issue specific to kirkstone. I will have a try with master and create a PR if it's needed.

@agherzan
Copy link
Owner

Please do so that we don't miss it as new versions evolve. Thanks.

@shr-project
Copy link
Contributor

@bigbearishappy Ping for PR for langdale, mickledore and master branches.

@agherzan FYI

@agherzan
Copy link
Owner

@bigbearishappy can you please push this to the branches mentioned above as MRs?

ywbyun0815 pushed a commit to webosose/meta-webosose that referenced this pull request Jan 17, 2024
:Release Notes:
Undo kirkstone specific change:
agherzan/meta-raspberrypi@80a12f7
which was not applied in langdale and newer branches, see:
agherzan/meta-raspberrypi#1209

:Detailed Notes:

:Testing Performed:
Only build tested.

:QA Notes:
No change to image.

:Issues Addressed:
[WRQ-5430] CCC: linux-raspberrypi: include vc4 and v3d in kernel

Cherry-picked-from-commit: efb98ce
Cherry-picked-from-branch:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants