Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail when only all_of is specified #248

Closed
vincetiu8 opened this issue Sep 3, 2021 · 5 comments
Closed

Tests fail when only all_of is specified #248

vincetiu8 opened this issue Sep 3, 2021 · 5 comments

Comments

@vincetiu8
Copy link

vincetiu8 commented Sep 3, 2021

workflow.yml:

jobs:
  check-labels:
    name: Check Labels
    runs-on: ubuntu-latest
    steps:
      - uses: agilepathway/[email protected]
        with:
          all_of: dependencies
          repo_token: ${{ secrets.GITHUB_TOKEN }}

expectation:

  • tests should pass, only checking tha all_of condition.

output:

Run agilepathway/[email protected]
/usr/bin/docker run --name c9e036bdf4c5186c704eeba3d0619efcea84d7_f9d086 --label c9e036 --workdir /github/workspace --rm -e INPUT_ALL_OF -e INPUT_REPO_TOKEN -e INPUT_ONE_OF -e INPUT_NONE_OF -e INPUT_ANY_OF -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_RETENTION_DAYS -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e GITHUB_ACTION_REPOSITORY -e GITHUB_ACTION_REF -e GITHUB_PATH -e GITHUB_ENV -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/palm/palm":"/github/workspace" c9e036:bdf4c5186c704eeba3d0619efcea84d7
Checking GitHub labels ...
Error: Label check failed: required 1 of , but found 0.
Label check failed: required any of , but found 0.
Label check successful: required none of , and found 0.
Label check successful: required all of dependencies, and found 1: dependencies
@johnboyes
Copy link
Contributor

Thanks for raising this @vincetiu8, I'll look into it over the weekend

@johnboyes
Copy link
Contributor

johnboyes commented Sep 3, 2021

I see that you are using a very old version of the label checker (v1.0.9). Could you try using the latest version (v1.0.103) and see if you get the same error?

@vincetiu8
Copy link
Author

vincetiu8 commented Sep 3, 2021

Error is resolved with latest branch!

FYI @johnboyes , the latest version on the Github Marketplace is v1.0.9, which is why I used it initially. Perhaps that should be updated?

@johnboyes
Copy link
Contributor

Wow, thanks v much for the feedback @vincetiu8, I wasn't aware and will rectify today!

@johnboyes
Copy link
Contributor

I've now published the latest version to the Marketplace, thanks again for the heads up @vincetiu8. Have also created #249 to make sure future releases aren't missed. Thanks for the feedback and hope the label checker works well for you - please let me know if you encounter any other issues or have any improvement suggestions 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants