Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User data in calculations #103

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

joAschauer
Copy link
Collaborator

Hi Markus @markushal,
the user data is now passed to the backend, give it a try. I had to remove the subregions from res_costs for the world map as otherwise the color for e.g. Argentina got displayed incorrectly when a value was changed for it.

In the long run, I guess we could think about making res_costs a session state variable.

@joAschauer joAschauer requested a review from markushal November 14, 2023 12:28
Copy link
Collaborator

@markushal markushal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the one comment I made, this looks great!

app/ptxboa_functions.py Show resolved Hide resolved
@markushal markushal self-requested a review November 14, 2023 13:46
Copy link
Collaborator

@markushal markushal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thank you!

@markushal markushal merged commit dcd0db8 into develop Nov 14, 2023
2 checks passed
@joAschauer joAschauer deleted the feat/use_user_data_in_calculations branch November 14, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants