105 move settings to session state #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joAschauer
reviewed
Nov 15, 2023
app/ptxboa_functions.py
Outdated
| @@ -147,8 +109,10 @@ def aggregate_costs(res_details: pd.DataFrame) -> pd.DataFrame: | |||
|
|
|||
| # Settings: | |||
| def create_sidebar(api: PtxboaAPI): | |||
| if "settings" not in st.session_state: | |||
| st.session_state["settings"] = {} | |||
There was a problem hiding this comment.
Is there a specific reason you put settings in a dictionary inside session state and do not place each entry in settings in the session state as an individual key? This would make code that accesses a single setting value more concise.
There was a problem hiding this comment.
Hmmm. I thought it would be nice to have all settings grouped together in a dictionary. But you are right, there is no real need for this. Good point.
joAschauer
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the
settingsdictionary tost.session_state["settings"]. keep in mind that unittests do not work for functions that callst.session_state. This is why I removed the legacycalculate_resultsfunction and the associated test.We should try to set up the streamlit testing framework #112
@joAschauer I hope these changes do not conflict with the work you are currently doing