Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce first test for streamlit app #114

Merged
merged 4 commits into from
Nov 16, 2023
Merged

introduce first test for streamlit app #114

merged 4 commits into from
Nov 16, 2023

Conversation

joAschauer
Copy link
Collaborator

closes #112

@joAschauer joAschauer requested a review from markushal November 16, 2023 09:24
markushal
markushal approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@markushal markushal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. VSCode did not find the new test, but running pytest from the command line did work.

@markushal markushal merged commit 1dfadb4 into develop Nov 16, 2023
3 checks passed
@joAschauer
Copy link
Collaborator Author

joAschauer commented Nov 16, 2023 •
edited
Loading

Great. VSCode did not find the new test, but running pytest from the command line did work.

worked for me. @markushal maybe you have reconfigure your tests in vs code to use pytest: Strg+Shift+P -> "Python: Configure Tests"

@wingechr wingechr deleted the feat/streamlit_tests branch November 22, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushal markushal markushal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joAschauer @markushal